Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing E2E_GROUPS / E2E_TEST for isolated e2e test runs #1363

Open
dtrudg opened this issue Feb 24, 2023 · 0 comments
Open

Consider removing E2E_GROUPS / E2E_TEST for isolated e2e test runs #1363

dtrudg opened this issue Feb 24, 2023 · 0 comments
Labels

Comments

@dtrudg
Copy link
Member

dtrudg commented Feb 24, 2023

Type of issue

technical debt

Description of issue

In the 3.11 cycle, we added E2E_GROUPS and E2E_TEST options to the e2e-tests make target to filter the tests that are run.

This was initially put in place because using scripts/e2e-test with -run was complicated by the two modes of e2e execution (with / without PID namespace) introduced when systemd cgroups management was added.

Additionally, it was felt that since make -C builddir e2e-test is the entry point to run the test suite, that it was friendly to put something there.

We did eventually implement process reaping, following apptainer... removing the PID namespace for all tests, so we don't actually have the two modes of e2e test execution now.

Perhaps it's better to promote running individual e2e tests with scripts/e2e-test -run xxxx instead? Needs explanation about the TestE2E/PAR and TestE2E/Seq prefix... etc.

Or is it that more confusing for people not familiar with go test... and we should leave the makefile driven filters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant