Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the range check for descriptor IDs #384

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Aug 23, 2024

Correct the range check for descriptor IDs. Check descriptor capacity during SIF creation, to avoid descriptor capacity that would overflow descriptor ID field.

@tri-adam tri-adam self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.41%. Comparing base (fd8a090) to head (6f00aba).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/sif/create.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   65.35%   65.41%   +0.05%     
==========================================
  Files          37       37              
  Lines        3259     3264       +5     
==========================================
+ Hits         2130     2135       +5     
  Misses        975      975              
  Partials      154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam tri-adam changed the title fix: correct the range checke for descriptor IDs fix: correct the range check for descriptor IDs Aug 23, 2024
@tri-adam tri-adam marked this pull request as ready for review August 23, 2024 16:01
@tri-adam tri-adam merged commit 1ed3ce5 into sylabs:main Aug 23, 2024
1 check passed
@tri-adam tri-adam deleted the overflow-fix branch August 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants