Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golangci-lint to v1.60 #383

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Aug 19, 2024

Bump golangci-lint to v1.60. Address lint, and remove deprecated linter.

@tri-adam tri-adam self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.35%. Comparing base (518b3a3) to head (d2a9ddc).
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/sif/create.go 64.70% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   65.42%   65.35%   -0.07%     
==========================================
  Files          37       37              
  Lines        3248     3259      +11     
==========================================
+ Hits         2125     2130       +5     
- Misses        971      975       +4     
- Partials      152      154       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam
Copy link
Member Author

The linter is failing here with code that passes on v1.59.x. Seems as though this is the same underlying issue as golangci/golangci-lint#4905, which was addressed in golangci/golangci-lint#4907. Looks like this should be addressed in the next release of golangci-lint, so will just keep this in draft for now.

@tri-adam tri-adam force-pushed the golangci-lint-v1.60 branch from 1b7e347 to d2a9ddc Compare August 22, 2024 20:57
@tri-adam tri-adam marked this pull request as ready for review August 22, 2024 20:58
@tri-adam tri-adam merged commit fd8a090 into sylabs:main Aug 23, 2024
1 check passed
@tri-adam tri-adam deleted the golangci-lint-v1.60 branch August 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants