Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Add support for custom requests session (to support exponential backoffs) #144

Open
TimidRobot opened this issue Oct 5, 2022 · 0 comments

Comments

@TimidRobot
Copy link

TimidRobot commented Oct 5, 2022

Issue

The requests session is currently hardcoded:

session = requests.Session()

Potential Solution

Easiest change would be to allow the user to specify the session in FlickrAPI() and pass it to OAuthFlickrInterface.

The the user could configure exponential backoff themselves:

from requests.adapters import HTTPAdapter
from requests.packages.urllib3.util.retry import Retry
    # Requests configurations
    max_retries = Retry(
        # try again after 5, 10, 20, 40, 80 seconds
        # for specified HTTP status codes
        total=5,
        backoff_factor=10,
        status_forcelist=[403, 408, 429, 500, 502, 503, 504],
    )
    session = requests.Session()
    session.mount("https://", HTTPAdapter(max_retries=max_retries))

etc.

Additional context

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant