Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make alignFormatter configurable #96

Closed
syavorsky opened this issue Nov 19, 2020 · 5 comments
Closed

make alignFormatter configurable #96

syavorsky opened this issue Nov 19, 2020 · 5 comments
Milestone

Comments

@syavorsky
Copy link
Owner

as per conversation in #93:

  • export alignFormatter and make it configurable
  • add the indent:number option
@syavorsky syavorsky added this to the 1.0 milestone Nov 19, 2020
@syavorsky
Copy link
Owner Author

@brettz9 @renatho I ended up splitting the transformation logic from stringifying. So at the end stringifier is just concatenating tokens together, but before that you can process them as you like. Check out this example. I hope, tweaking the formatting should be easy enough with custom hooks, see what align and indent do

@brettz9
Copy link
Contributor

brettz9 commented Dec 27, 2020

Thanks for the heads up, and happy to see these transforms available. Hopefully the approach won't add too much to execution time. I'm unfortunately not in a position to try them out myself these days, though hopefully I can by the time you feel it is ready for a release. Thanks much!

@syavorsky
Copy link
Owner Author

@brettz9 no probs, tweaking transforms as needed later should not be a problem

@renatho
Copy link

renatho commented Jan 4, 2021

Thank you @syavorsky!
Nice approach about the transforms 👏 I think it'll be easy to implement and it'll also create new possibilities for the lib! \o/

@syavorsky
Copy link
Owner Author

@renatho no prob, I should thank you indeed for kicking off the whole 1.0 refactoring :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants