Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sync scrolling resolution #786

Closed
2 tasks
alcarney opened this issue Apr 23, 2024 · 0 comments · Fixed by #851
Closed
2 tasks

Improve sync scrolling resolution #786

alcarney opened this issue Apr 23, 2024 · 0 comments · Fixed by #851
Labels
enhancement New feature or request lsp Issues that relate to the language server
Milestone

Comments

@alcarney
Copy link
Member

What would you like to see

Right now sync scrolling works, but depending on document content the resolution is a little coarse. This can be tackled on two fronts

  • Extend the line number transform to pass through line numbers from more node types
  • Update the sync logic in webview.js to search for the nearest matching number, (it currently only works if asked to scroll to a line number that matches exactly with the available numbers)
@alcarney alcarney added enhancement New feature or request lsp Issues that relate to the language server labels Apr 23, 2024
@alcarney alcarney added this to the 1.0 milestone Apr 23, 2024
@alcarney alcarney added this to Esbonio Apr 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in Esbonio Apr 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Esbonio Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lsp Issues that relate to the language server
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant