Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension can hang while checking Python version #493

Closed
alcarney opened this issue Nov 18, 2022 · 2 comments
Closed

Extension can hang while checking Python version #493

alcarney opened this issue Nov 18, 2022 · 2 comments
Labels
bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension

Comments

@alcarney
Copy link
Member

alcarney commented Nov 18, 2022

[client] Python extension is available
[client] Activating python extension
[client] Running Command: /.../bin/python -c import sys ; print("{0.major}.{0.minor}.{0.micro}".format(sys.version_info))

If this command fails (such as when the configured Python does not exist), then the extension will hang as the error is not appropriately handled

@alcarney alcarney added bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension labels Nov 18, 2022
@lextm
Copy link
Contributor

lextm commented Nov 24, 2022

A separate but related topic is that I found promisify(child_process.execFile) a ridiculous wrapper that cannot throw critical errors out (if you happen to quote the last parameter as "import .....". Pretty sad that it is not a reliable way yet to perform just the essential tasks like spinning out another process.

@alcarney
Copy link
Member Author

This will no longer be an issue when the VSCode extension hits v1.0
See #609 for more details

@github-project-automation github-project-automation bot moved this from Todo to Done in Esbonio Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension
Projects
Status: Done
Development

No branches or pull requests

2 participants