Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port @mui/lab ? #70

Closed
Brian-McBride opened this issue May 26, 2022 · 3 comments
Closed

Port @mui/lab ? #70

Brian-McBride opened this issue May 26, 2022 · 3 comments

Comments

@Brian-McBride
Copy link

Will your React2Solid here also port over the @mui/lab

Also, with tree-shaking these days, it sure is handy to import like

import {Stack, Typography} from '@mui/material

vs. a separate import on each line. When I was messing around in the sandbox, it seemed like this conversion was forcing explicitly importing each item separately. Not a problem, just convenience.

@juanrgm
Copy link
Member

juanrgm commented May 26, 2022

Will your React2Solid here also port over the @mui/lab

@suid/codemod have two actions:

  • react2solid
  • mui2suid (WIP)

Now, React2Solid is executing the react2solid action. For transforming a @mui component will be neccesary to use the mui2suid action. Nonetheless, only @mui/material will be totally ported, the rest of packages are not a priority.

Also, with tree-shaking these days, it sure is handy to import like

Three-shaking is not the problem. The problem is TypeScript. When you import a file that contains other imports, all type definitions are loaded into the memory and since MUI/SUID is a large project, the IDE autocomplete and live reloading will be slowed down.

This problem is documented here.

Also, MUI is having a lot of performance issues when you are developing with TypeScript, so it is very important to avoid bringing the same problems to SUID.

@Brian-McBride
Copy link
Author

Hrm, I guess my computer has been fast enough not to notice the MUI package slowing it down (I'm exclusively TS these days.) But that is good to know and I can get behind IDE performance.

I very much look forward to your progress here. It would be nice if the MUI guys would move the datetime pickers into the main lib. It seems odd they are still in the lab repo.

@juanrgm
Copy link
Member

juanrgm commented May 29, 2022

There was a channel communication between core teams (TypeScript/MUI) for trying fix the typings performance but no luck (microsoft/TypeScript#34801).

Now, MUI core team is retaking the issue in mui/material-ui#19113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants