Added openswoole extension check compatibility #506
Conversation
Swoole now became `openswoole`, from version 4.7.2 swoole extension changed as openswoole. For this reason, this package can not detect the extension and shows the message *Can't detect Swoole extension installed.* This commit fixed the issue.
| @@ -370,7 +370,7 @@ protected function checkEnvironment() | |||
| exit(1); | |||
| } | |||
|
|
|||
| if (! extension_loaded('swoole')) { | |||
| if (! extension_loaded('swoole') && ! extension_loaded('openswoole')) { | |||
There was a problem hiding this comment.
shouldn't this be an or statement?
...
if (! extension_loaded('swoole') or ! extension_loaded('openswoole')) {
...There was a problem hiding this comment.
@Arkanius thanks for your reply. Nope it will be and operator. bcoz Sometimes one of the two may be available but it does not mean that one of them missing means others is not available. when both of them are missing then we should show the message.
|
Thanks for your contribution! Sorry, I was on vacation and couldn't see this before. I've just one doubt, please check my review |
|
@Arkanius please check the review |
|
Got it! You're right! we'll apply your PR! Thanks for contributing! |
|
When it will be released? (: |
|
Hi @Arkanius Please release this minor change. Otherwise, we need to Extend the Command and Service Provider in our code, just to get OpenSwoole working with Laravel |
|
@madhurbhaiya @ErriourRU sorry by my late response here guys, I had some problems and was really busy, I'm sorry again =/ Well, it's merged, but please, test it out and check if your apps is running well. I'll be wating your answer |
Swoole now became
openswoole, from version 4.7.2 swoole extension changed as openswoole. For this reason, this package can not detect the extension and shows the message Can't detect Swoole extension installed. This commit fixed the issue.