This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Websocket - Sandbox missing for disconnect event #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, follow the issue guideline |
|
@Arkanius There is no issue template when creating pull requests. What would you like me to elaborate on? It seems pretty clear to me, especially that this is a few-liner (but essential). |
|
Oh, sorry @netdown ! I misread it (apparently I confused with another PR) and I thougth you were referencing an issue without guideline, my bad 😅 Your PR is fine, I'll merge it and it will be present on the next release, thanks! |
Arkanius
approved these changes
Aug 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sandbox must be created even when disconnect event is dispatched, because for example the providers are not set otherwise. In my specific case, I would like to log the disconnection of the user, but authentication guards do not work without this.