Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

PHP 8.0 Support? #454

Closed
jiangjiangdev opened this issue Dec 3, 2020 · 12 comments
Closed

PHP 8.0 Support? #454

jiangjiangdev opened this issue Dec 3, 2020 · 12 comments
Labels

Comments

@jiangjiangdev
Copy link

I have updated PHP to version 8.0
so... you know

@Arkanius
Copy link
Contributor

Arkanius commented Dec 3, 2020

Hi @jiangjiang0228 !

I'm looking foward to it! Unfortunatelly, I hadn't enough time to test PHP 8 with this package yet, but we have a branch with php8 support. Do you want to help us test it? :)

@jiangjiangdev
Copy link
Author

@Arkanius
Thx!
Im using the branch

@Arkanius
Copy link
Contributor

Arkanius commented Dec 3, 2020

Nice! Please, let us know if your app is working properly as it was with the early versions of php

@slava-vishnyakov
Copy link

Thanks! Just in case anyone is Googling this:

composer require swooletw/laravel-swoole:dev-improvement/php8 seems to work

@kocoten1992
Copy link
Contributor

Anyone get into any issue ? I've using for a while, didn't got any trouble, just want to let you know!

@Arkanius
Copy link
Contributor

@kocoten1992 nice to hear that!

@amcsi
Copy link
Contributor

amcsi commented Feb 12, 2021

I can confirm that the php8 branch has been working for me fine for a few weeks. It's a personal project though where the website isn't visited often.

@Arkanius
Copy link
Contributor

Nice to hear that. So, I think that in a couple weeks it's a good time to release the support to php8

@amcsi
Copy link
Contributor

amcsi commented Mar 10, 2021

I still haven't had any problems with the php8 branch in my small, personal project.

@Arkanius
Copy link
Contributor

Nice job. are you using websockets or your app is request based?

@amcsi
Copy link
Contributor

amcsi commented Mar 10, 2021

@Arkanius request-based. No websockets.

It's open source by the way: https://github.com/amcsi/lycee-overture

@Arkanius
Copy link
Contributor

Applied as https://github.com/swooletw/laravel-swoole/releases/tag/v2.8.0

Thanks everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants