Checking if the loginUrl already contains a "?" fails

[matleppa]

In file meteor-accounts-oidc/packages/switch_oidc/oidc_client.js it si checked, if loginUrl already contains a "?".

The checking is done with this piece of code:

  // check if the loginUrl already contains a "?"
  var first = !loginUrl.indexOf('?') === -1;
  for (var k in options) {
    if (first) {
      loginUrl += '?';
      first = false;
    }
    else {
      loginUrl += '&'
    }
    loginUrl += encodeURIComponent(k) + '=' + encodeURIComponent(options[k]);
  }

It seems that it is trying to return the negation of status, whether "?" is included in URL or not.
However, it returns always false, which then later is interpreted, that the "?" was present.

So in case "?" was not there, it is not added, thus causing sent request to fail.

I think that the correct piece of code were following:

var first = loginUrl.indexOf('?') === -1;

Of course there is a workaround: always add "?" in the loginURL, but the bug should be fixed, the sooner the better.

[valerytschopp]

Hi @matleppa, can you provide a pull request for this change?
Thanks