Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[component]: Text input #3270

Open
6 of 7 tasks
Tracked by #3696
Cian77 opened this issue Jul 16, 2024 · 7 comments · May be fixed by #3946
Open
6 of 7 tasks
Tracked by #3696

[component]: Text input #3270

Cian77 opened this issue Jul 16, 2024 · 7 comments · May be fixed by #3946
Assignees
@leagrdv
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
PPNL Components

Comments

@Cian77
Copy link

Cian77 commented Jul 16, 2024 •
edited by leagrdv
Loading

Description

Create a HTML/CSS component using the current markup that implements as many features as possible from the new Design. Remove any dependencies on bootstrap for this component. This is done for backwards compatibility reasons. The current structure will eventually be deprecated. These styles will give us the necessary time to come up with a solid input component strategy.

Open issues:

Design:

  • Integrated and tested new Typography
  • Integrated new Icons
  • Spacing is defined

Tokens:

  • text

Design

https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=21-168

Tokens

@use 'sass:map';
@use './../tokens/components' as tokens;

// to see the available component tokens
@each $key in map.keys(tokens.$post-text-input) {
  @debug $key;
}

input {
  {property}: map.get(tokens.$post-text-input, {token-name});
}

Tasks

💻 Tasks
Beta Give feedback
@Cian77 Cian77 added the 📦 components Related to the @swisspost/design-system-components package label Jul 16, 2024
@Cian77 Cian77 added this to the Components v2 milestone Jul 16, 2024
@gfellerph gfellerph changed the title Text input: [component]: Text input Jul 22, 2024
@gfellerph gfellerph added the needs: discussion There is at least one topic in the pattern descussion meeting about the issue label Jul 24, 2024
@gfellerph
Copy link
Member

After discussion with @sandrahohl-post, small variants and dark mode will be added in a later iteration.

@gfellerph gfellerph moved this from 👀 Triage to 💎 Ready for development in Design System Production Board Jul 24, 2024
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package and removed needs: discussion There is at least one topic in the pattern descussion meeting about the issue 📦 components Related to the @swisspost/design-system-components package labels Jul 24, 2024
@gfellerph
Copy link
Member

gfellerph commented Jul 26, 2024 •
edited
Loading

Open point: validation message (create a component? is icon in validation message?) -> #3353

Component token names are under discussion as well -> #3356

@gfellerph gfellerph added the needs: discussion There is at least one topic in the pattern descussion meeting about the issue label Jul 26, 2024
@gfellerph gfellerph added needs: discussion There is at least one topic in the pattern descussion meeting about the issue and removed needs: discussion There is at least one topic in the pattern descussion meeting about the issue labels Aug 8, 2024
@gfellerph gfellerph mentioned this issue Aug 8, 2024
Closed
@Cian77
Copy link
Author

Cian77 commented Aug 12, 2024

Integrated new Typography and Icons.

@gfellerph gfellerph removed the needs: discussion There is at least one topic in the pattern descussion meeting about the issue label Aug 20, 2024
@alizedebray alizedebray self-assigned this Aug 20, 2024
@alizedebray alizedebray moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Aug 20, 2024
@alizedebray alizedebray moved this from 🕹️ Coding in progress to 💻 Ready for development in Design System Production Board Aug 20, 2024
@Vandapanda Vandapanda moved this from 🔮 Ready for tokenisation to 💻 Ready for development in Design System Production Board Aug 27, 2024
@alizedebray alizedebray moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Sep 3, 2024
@alizedebray alizedebray linked a pull request Sep 4, 2024 that will close this issue
feat(styles): new floating label inputs #3493
Closed
@alizedebray alizedebray added the on hold Wait for something to be done, before continue working on this Issue label Sep 9, 2024
@alizedebray
Copy link
Contributor

alizedebray commented Sep 9, 2024 •
edited
Loading

Waiting for the tokens to be updated.

@oliverschuerch
Copy link
Contributor

@alizedebray would it be ok to move this ticket to "Ready for tokenisation" again and assign it to @Vandapanda (without unassign yourself)?
@Cian77 will update the integration of the text input in Figma and let us know, as soon as @Vandapanda can work on it again.

@Vandapanda
Copy link
Contributor

Assigned @Cian77 as its in redesign atm. Would recommend to move it to "Design in Progress" as its not ready for tokenisation right now if thats fine with you @alizedebray

@gfellerph gfellerph modified the milestones: Design v2, Cargo Components Oct 1, 2024
@gfellerph
Copy link
Member

New Design is approved.

@gfellerph gfellerph removed the on hold Wait for something to be done, before continue working on this Issue label Oct 11, 2024
@alizedebray alizedebray moved this from 🕹️ Coding in progress to 🔮 Ready for tokenisation in Design System Production Board Oct 29, 2024
@gfellerph gfellerph removed the v9 label Oct 30, 2024
@gfellerph gfellerph mentioned this issue Nov 7, 2024
Open
1 task
@leagrdv leagrdv linked a pull request Nov 8, 2024 that will close this issue
feat(component): text input #3946
Open
@Vandapanda Vandapanda removed their assignment Nov 11, 2024
@leagrdv leagrdv moved this from 🕹️ Coding in progress to 🤬 Dev in review in Design System Production Board Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leagrdv leagrdv

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🤬 Dev in review
Milestone
PPNL Components
6 participants
@gfellerph @oliverschuerch @alizedebray @Cian77 @Vandapanda @leagrdv