Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons declaration #3375

Closed
alizedebray opened this issue Aug 5, 2024 · 0 comments · Fixed by #3482
Closed

Update icons declaration #3375

alizedebray opened this issue Aug 5, 2024 · 0 comments · Fixed by #3482
Assignees
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package v8

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Aug 5, 2024

Angular 18 offers to migrate to a new build system.
However, when doing so the build results in an error with the icons.

To avoid this error, the icons should be declared as:

// RIGHT
$_accordion-button-icon: icons.get-colored-svg-url(2113, $accordion-button-color);
$accordion-button-icon: url('#{$_accordion-button-icon}');

// WRONG
$accordion-button-icon: url('#{icons.get-colored-svg-url(2113, $accordion-button-color)}');
@alizedebray alizedebray self-assigned this Aug 5, 2024
@alizedebray alizedebray converted this from a draft issue Aug 5, 2024
@alizedebray alizedebray added 🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package labels Aug 5, 2024
@alizedebray alizedebray moved this from 🕹️ Coding in progress to 👀 Triage in Design System Production Board Aug 5, 2024
@alizedebray alizedebray removed their assignment Aug 6, 2024
@gfellerph gfellerph added the v8 label Aug 8, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Aug 22, 2024
@schaertim schaertim self-assigned this Aug 28, 2024
@schaertim schaertim moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Aug 29, 2024
@schaertim schaertim linked a pull request Aug 29, 2024 that will close this issue
@schaertim schaertim closed this as completed by moving to 🚀 Done in Design System Production Board Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package v8
Projects
Development

Successfully merging a pull request may close this issue.

3 participants