Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disabled button in the accessibility documentation #3367

Closed
1 task done
alizedebray opened this issue Jul 31, 2024 · 1 comment · Fixed by #3403
Closed
1 task done

Remove disabled button in the accessibility documentation #3367

alizedebray opened this issue Jul 31, 2024 · 1 comment · Fixed by #3403
Assignees
@schaertim
Labels
🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package good first issue Good for newcomers request

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Jul 31, 2024 •
edited by schaertim
Loading

I you fill in the "Good example" form in the accessibility documentation and submit it, then the button is disabled while loading.

This button should actually be enabled, and the event prevented.

Tasks
Beta Give feedback
@alizedebray alizedebray added request 🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package labels Jul 31, 2024
@gfellerph
Copy link
Member

Discussion: not disabling is better, when button is disabled, it looses focus.

@gfellerph gfellerph added the good first issue Good for newcomers label Aug 13, 2024
@schaertim schaertim self-assigned this Aug 13, 2024
@schaertim schaertim moved this from 👀 Triage to 💎 Ready for development in Design System Production Board Aug 14, 2024
@schaertim schaertim linked a pull request Aug 14, 2024 that will close this issue
chore(docs): Removed disabled button in accessibility docs and added explanation #3403
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schaertim schaertim

Labels
🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package good first issue Good for newcomers request
Projects
Design System Production Board
Archived in project
Milestone
No milestone
3 participants
@gfellerph @alizedebray @schaertim