Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCM Light/Dark: Forms invalid and valid feedback + border colors should be kept #2642

Closed
imagoiq opened this issue Feb 14, 2024 · 5 comments · Fixed by #2766
Closed

HCM Light/Dark: Forms invalid and valid feedback + border colors should be kept #2642

imagoiq opened this issue Feb 14, 2024 · 5 comments · Fixed by #2766
Assignees
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package

Comments

@imagoiq
Copy link
Contributor

imagoiq commented Feb 14, 2024

Currently, only the check icon color is kept on input and select and there is no way to differentiate valid and invalid with a checkbox for example.
https://next.design-system.post.ch/?path=/docs/patterns-forms--docs#validation-messages

Image

@gfellerph
Copy link
Member

@Cian77 do you have suggestions for styling errors and success messages in HCM?

@gfellerph gfellerph added 🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package needs: design This issue needs a design in figma before it can be implemented. labels Feb 14, 2024
@gfellerph
Copy link
Member

@imagoiq set validation icon color to text color

@gfellerph gfellerph removed the needs: design This issue needs a design in figma before it can be implemented. label Mar 1, 2024
@imagoiq imagoiq self-assigned this Mar 4, 2024
@imagoiq imagoiq moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Mar 4, 2024
@imagoiq imagoiq moved this from 🏗 In progress to 👀 In review in Design System Production Board Mar 4, 2024
@imagoiq
Copy link
Contributor Author

imagoiq commented Mar 4, 2024

@imagoiq set validation icon color to text color

@gfellerph Can you please clarify, your sentence is ambiguous. Setting the validation icon color to white on dark background would not fix the issue as the background of the feedback is still highlighted on valid or invalid state.

@imagoiq imagoiq moved this from 👀 In review to 📋 Backlog in Design System Production Board Mar 4, 2024
@gfellerph
Copy link
Member

There are not enough colors to distinguish between valid/invalid state in HCM (and the other available colors have a different meaning https://www.smashingmagazine.com/2022/06/guide-windows-high-contrast-mode/ but I'm sure you know that already). I'd argue that the highlight color is useful for directing attention towards the field.

As we had a look at the screenshot, we noticed that the only other identifier, the icon, is barely visible. Therefore we decided that it would be best to make this identifier more visible by giving it the same color as text. What do you think?

@imagoiq imagoiq moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Mar 6, 2024
@imagoiq imagoiq moved this from 🏗 In progress to 👀 In review in Design System Production Board Mar 6, 2024
@imagoiq
Copy link
Contributor Author

imagoiq commented Mar 6, 2024

There are not enough colors to distinguish between valid/invalid state in HCM (and the other available colors have a different meaning https://www.smashingmagazine.com/2022/06/guide-windows-high-contrast-mode/ but I'm sure you know that already). I'd argue that the highlight color is useful for directing attention towards the field.

As we had a look at the screenshot, we noticed that the only other identifier, the icon, is barely visible. Therefore we decided that it would be best to make this identifier more visible by giving it the same color as text. What do you think?

I went with "Mark" color instead of "Highlight" for the background color, because according to mdn "Hightlight" is for "Background of selected items" and then it's difficult to distinguish between selected input and the rest. #2766

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Projects
Development

Successfully merging a pull request may close this issue.

2 participants