-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update font definitions to remove font-weight: light #2614
Comments
There is still a light font-face in the figma file. Clearification wanted! |
@oliverschuerch the change is scoped to body copy. Subtitles still use light. |
@oliverschuerch can you check if font styles are updated to regular and close this ticket if they are? |
Font styles are not updated now.
|
@gfellerph The .carousel-caption .light class is used like a subtitle and the whole selector looks like this: .carousel-caption {
.subtitle,
.light {
font-size: type.$font-size-small-big;
font-weight: type.$font-weight-light;
}
} Should we keep this? |
@gfellerph What should be updated in the typography documentation? |
The carousel is deprecated and will be removed soon, no need to do anything right now. |
As the font is still available and used, I'll keep this as is. Might change with the new font and v2 anyway. |
Font definitions have been updated and the light font variant has been removed for most use cases.
Design: https://www.figma.com/file/ojCcgC5Zd12eUSzq6V5m24/Foundations-Post?type=design&node-id=3%3A950&mode=design&t=mfN0rhDtnbsAvzHT-1
Tasks
The text was updated successfully, but these errors were encountered: