Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font definitions to remove font-weight: light #2614

Closed
2 of 3 tasks
gfellerph opened this issue Feb 6, 2024 · 8 comments · Fixed by #3284
Closed
2 of 3 tasks

Update font definitions to remove font-weight: light #2614

gfellerph opened this issue Feb 6, 2024 · 8 comments · Fixed by #3284
Assignees
Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 📦 styles Related to the @swisspost/design-system-styles package

Comments

@gfellerph
Copy link
Member

gfellerph commented Feb 6, 2024

Font definitions have been updated and the light font variant has been removed for most use cases.

Design: https://www.figma.com/file/ojCcgC5Zd12eUSzq6V5m24/Foundations-Post?type=design&node-id=3%3A950&mode=design&t=mfN0rhDtnbsAvzHT-1

Tasks

Preview Give feedback
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Feb 7, 2024
@gfellerph gfellerph added this to the Design - Implementation Sync milestone Feb 7, 2024
@oliverschuerch
Copy link
Contributor

oliverschuerch commented Feb 28, 2024

There is still a light font-face in the figma file. Clearification wanted!
@rouvenpost can you please have a look.

@oliverschuerch oliverschuerch added the needs: design This issue needs a design in figma before it can be implemented. label Feb 28, 2024
@gfellerph
Copy link
Member Author

@oliverschuerch the change is scoped to body copy. Subtitles still use light.

@gfellerph gfellerph removed needs: design This issue needs a design in figma before it can be implemented. needs: refinement labels Mar 1, 2024
@github-actions github-actions bot added the stale label Jun 4, 2024
@gfellerph
Copy link
Member Author

@oliverschuerch can you check if font styles are updated to regular and close this ticket if they are?

@gfellerph gfellerph added the 🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem label Jul 15, 2024
@github-actions github-actions bot removed the stale label Jul 15, 2024
@oliverschuerch oliverschuerch moved this from 🗃️ Ready for work to 🕹️ Coding in progress in Design System Production Board Jul 17, 2024
@oliverschuerch
Copy link
Contributor

oliverschuerch commented Jul 17, 2024

Font styles are not updated now.
Selectors/Variables that still use $font-weight-light, but shouldn't:

  • header.navbar .search-textbox input (file: components/intranet-header/_searchbox.scss)
  • #navbarsDefault > ul > .nav-item (file: components/intranet-header/_top-navigation.scss)
  • @mixin styles { p } (file: layouts/portal/_type.scss)
  • %list-adjustment { ul li } (file: placeholders/_text.scss)
  • %text-container { ul li } (file: placeholders/_text.scss)
  • %text-container { ol li } (file: placeholders/_text.scss)
  • $blockquote-cite-font-weight (file: variables/_type.scss)
  • $accordion-body-font-weight (file: variables/components/_accordion.scss)
  • $notification-font-weight (file: variables/components/_notification.scss)

@oliverschuerch
Copy link
Contributor

@gfellerph The .carousel-caption .light class is used like a subtitle and the whole selector looks like this:

.carousel-caption {
  .subtitle,
  .light {
    font-size: type.$font-size-small-big;
    font-weight: type.$font-weight-light;
  }
}

Should we keep this?

@oliverschuerch
Copy link
Contributor

@gfellerph What should be updated in the typography documentation?
Do you just want to remove the light font face from the docs page?

Image

@gfellerph
Copy link
Member Author

@gfellerph The .carousel-caption .light class is used like a subtitle and the whole selector looks like this:

.carousel-caption {
  .subtitle,
  .light {
    font-size: type.$font-size-small-big;
    font-weight: type.$font-weight-light;
  }
}

Should we keep this?

The carousel is deprecated and will be removed soon, no need to do anything right now.

@gfellerph
Copy link
Member Author

@gfellerph What should be updated in the typography documentation?
Do you just want to remove the light font face from the docs page?

Image

As the font is still available and used, I'll keep this as is. Might change with the new font and v2 anyway.

@oliverschuerch oliverschuerch moved this from 🕹️ Coding in progress to 🤬 Dev in review in Design System Production Board Jul 18, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 📦 styles Related to the @swisspost/design-system-styles package
Projects
Development

Successfully merging a pull request may close this issue.

4 participants