Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon component story flip-h and flip-v controls #2427

Closed
oliverschuerch opened this issue Dec 21, 2023 · 1 comment · Fixed by #2501
Closed

Fix icon component story flip-h and flip-v controls #2427

oliverschuerch opened this issue Dec 21, 2023 · 1 comment · Fixed by #2501
Assignees
@imagoiq
Labels
🐞 bug Something isn't working

Comments

@oliverschuerch
Copy link
Contributor

There are multiple flip-h and flip-v controls available in the story controls.

Two of them are coming from the web-component (they do not work in the story), two are self made controls (they work as expected).
There seems to be a problem with the way, they are implemented in the HTML.

image
@oliverschuerch oliverschuerch added 🐞 bug Something isn't working storybook labels Dec 21, 2023
@oliverschuerch oliverschuerch added this to the Maintenance milestone Dec 21, 2023
@alizedebray
Copy link
Contributor

Using the SpreadArgsDirective will probably fix the issue with the case.

@gfellerph gfellerph removed this from the Maintenance milestone Jan 12, 2024
@imagoiq imagoiq self-assigned this Jan 15, 2024
@imagoiq imagoiq moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Jan 15, 2024
@imagoiq imagoiq moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Jan 16, 2024
@imagoiq imagoiq linked a pull request Jan 16, 2024 that will close this issue
fix(docs): Clean icon component controls from duplicate and null values #2501
Merged
@imagoiq imagoiq moved this from 🏗 In progress to 👀 In review in Design System Production Board Jan 16, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imagoiq imagoiq

Labels
🐞 bug Something isn't working
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docs): Clean icon component controls from duplicate and null values swisspost/design-system
4 participants
@gfellerph @oliverschuerch @imagoiq @alizedebray