Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define default background color as white #2123

Closed
1 task
gfellerph opened this issue Oct 24, 2023 · 1 comment · Fixed by #3142
Closed
1 task

Define default background color as white #2123

gfellerph opened this issue Oct 24, 2023 · 1 comment · Fixed by #3142
Assignees
@davidritter-dotcom
Labels
📦 styles Related to the @swisspost/design-system-styles package

Comments

@gfellerph
Copy link
Member

gfellerph commented Oct 24, 2023 •
edited
Loading

For the .bg-xxx color system to work, a standard background color for the whole document needs to be set as default (like .bg-white but applied with the mixin to the body of the document), otherwise custom CSS properties like --post-bg-rgb are not set for the default light mode.

Tasks
Preview Give feedback
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Oct 24, 2023
@gfellerph gfellerph mentioned this issue Oct 24, 2023
Merged
@gfellerph gfellerph added the on hold Wait for something to be done, before continue working on this Issue label Nov 8, 2023
@gfellerph
Copy link
Member Author

wait for color discussion

@github-actions github-actions bot added the stale label Feb 13, 2024
@gfellerph gfellerph removed on hold Wait for something to be done, before continue working on this Issue stale labels Feb 15, 2024
@github-actions github-actions bot added the stale label May 15, 2024
@gfellerph gfellerph removed the stale label May 29, 2024
@davidritter-dotcom davidritter-dotcom self-assigned this Jun 5, 2024
@davidritter-dotcom davidritter-dotcom moved this from 🗃️ Ready for work to 💎 Ready for development in Design System Production Board Jun 5, 2024
@davidritter-dotcom davidritter-dotcom moved this from 💎 Ready for development to 🕹️ Dev in progress in Design System Production Board Jun 5, 2024
@davidritter-dotcom davidritter-dotcom linked a pull request Jun 5, 2024 that will close this issue
feat(styles): use the mixin to define the light variables on the body #3142
Merged
@davidritter-dotcom davidritter-dotcom moved this from 🕹️ Dev in progress to 🤬 Dev in code review in Design System Production Board Jun 6, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in code review to 🚀 Ready to use (done) in Design System Production Board Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidritter-dotcom davidritter-dotcom

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(styles): use the mixin to define the light variables on the body swisspost/design-system
2 participants
@gfellerph @davidritter-dotcom