Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated font-size variables #1301

Closed
4 tasks
Tracked by #1215
gfellerph opened this issue Mar 24, 2023 · 1 comment
Closed
4 tasks
Tracked by #1215

Remove deprecated font-size variables #1301

gfellerph opened this issue Mar 24, 2023 · 1 comment
Labels
💔 BREAKING This is a breaking change and results in a new major version good first issue Good for newcomers 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Breaking changes

Comments

@gfellerph
Copy link
Member

gfellerph commented Mar 24, 2023 •
edited by schaertim
Loading

With https://github.com/swisspost/design-system/pull/1298/files, the named font-size variables have been deprecated. These variables can be removed with the next major version and the usage across the Design System can be updated to the new variables. This is a breaking change because the new variables cannot be mapped 1:1 due to changes in font-size.

Tasks
Beta Give feedback
  4. Write migration instructions (inform about removal) #3399
    v9 📦 documentation
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package 💔 BREAKING This is a breaking change and results in a new major version labels Mar 24, 2023
@gfellerph gfellerph added this to the Next milestone Mar 24, 2023
@gfellerph gfellerph mentioned this issue Mar 24, 2023
Open
@gfellerph gfellerph modified the milestones: Next, Breaking changes Jul 15, 2024
@gfellerph gfellerph added the good first issue Good for newcomers label Aug 8, 2024
@schaertim schaertim assigned schaertim and unassigned schaertim Aug 14, 2024
@github-project-automation github-project-automation bot moved this from 🕹️ Coding in progress to 🚀 Done in Design System Production Board Aug 15, 2024
@schaertim
Copy link
Contributor

Replacing the font-size variables does not make sense at this point because it would have to be reworked with the implantation of the tokens anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💔 BREAKING This is a breaking change and results in a new major version good first issue Good for newcomers 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Breaking changes
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/1301-remove-deprecated-font-size-variables swisspost/design-system
2 participants
@gfellerph @schaertim