Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable property doesn't work #493

Closed
manueledones opened this issue Dec 20, 2016 · 1 comment
Closed

Disable property doesn't work #493

manueledones opened this issue Dec 20, 2016 · 1 comment

Comments

@manueledones
Copy link

manueledones commented Dec 20, 2016 •
edited
Loading

The disable property doesn't seem to work properly, even on the demo on your website:
Website

The problem should be here:

if (root.selectableSubMenu && (!opt.items[key] || $this.is('.' + root.classNames.disabled + ', .context-menu-submenu, .context-menu-separator, .' + root.classNames.notSelectable))) { return; }
root.selectableSubMenu returns false
@bbrala
Copy link
Member

bbrala commented Dec 22, 2016

Thanks for reporting. I'll simplify that construction,. :)

@bbrala bbrala closed this as completed in 4b419fe Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbrala @manueledones