Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to click submenus #483

Closed
zyuhel opened this issue Dec 8, 2016 · 2 comments
Closed

Ability to click submenus #483

zyuhel opened this issue Dec 8, 2016 · 2 comments
Labels

Comments

@zyuhel
Copy link
Contributor

zyuhel commented Dec 8, 2016

occasionally It is a useful ability to click on items containing submenus. For example if menu is used for tree categories selector.
I have made a Pull request #481 adding option for this.

@bbrala
Copy link
Member

bbrala commented Dec 9, 2016

Thanks! Merged the branch.

@bbrala bbrala closed this as completed Dec 9, 2016
@bbrala bbrala added the Feature label Dec 9, 2016
@CipherTrustee
Copy link

CipherTrustee commented Dec 4, 2019

@bbrala

There may be a regression on this feature...it fails because the key for an item that is a submenu is unknown at the time of a click event:

// abort if the key is unknown or disabled or is a menu

 if (!opt.items[key] || $this.is('.' + root.classNames.disabled + ', .context-menu-separator, .' + root.classNames.notSelectable) || ($this.is('.context-menu-submenu') && root.selectableSubMenu === false )) {
                    return;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants