Support docker v0.8 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the impact on us re: the 2 methods that no longer work? |
|
API 1.9 is out - any reason we're not using that instead of 1.8? |
|
@adamjt regarding your first question -- no. "No longer work" may not have been the correct term. They are very specific use-cases that have easy workarounds. The former should never impact us so long as we ensure that we copy the correct files. We never used the second way of running an Image. Regarding your second question, ask @bfulton. |
|
Ah, ok. So these are Docker bugs that should be resolved (hopefully) on their end? |
|
@adamjt yes. |
|
| @@ -140,7 +140,8 @@ def all(opts = {}, conn = Docker.connection) | |||
| def search(query = {}, connection = Docker.connection) | |||
| body = connection.get('/images/search', query) | |||
| hashes = Docker::Util.parse_json(body) || [] | |||
| hashes.map { |hash| new(connection, hash['Name']) } | |||
| puts hashes | |||
|
@tlunter I updated the repo to your suggestions. |
|
+1 |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bfulton @tlunter @adamjt
Not very many code changes were required, but two methods no longer work (due to errors in the Docker server). The first is
Container#copywill not raise an error if the specified file does not exist. The second isContainer#commitwill not properly copy over therunconfiguration.