Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the final binary after transformations are applied #327

Open
MaxDesiatov opened this issue May 4, 2022 · 0 comments
Open

Validate the final binary after transformations are applied #327

MaxDesiatov opened this issue May 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@MaxDesiatov
Copy link
Collaborator

Currently, if WasmTransformer or the SwiftWasm toolchain produce invalid binaries, our users can only discover this when loading the binary in a Wasm host (the browser in most cases). We should detect invalid binaries earlier for better user experience.

In certain cases some of the transformations (I64ImportTransformer for example) can produce invalid binaries. Of course such transformations should be fixed in the first place to avoid this, but I think it would be better long-term to have a validation pass built-in for better diagnostics.

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant