Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host JSKit entrypoint assets on GH Pages CDN #317

Closed
MaxDesiatov opened this issue Apr 11, 2022 · 1 comment
Closed

Host JSKit entrypoint assets on GH Pages CDN #317

MaxDesiatov opened this issue Apr 11, 2022 · 1 comment
Labels
refactor No user-visible functionality change

Comments

@MaxDesiatov
Copy link
Collaborator

Currently these assets are attached to a previous release relative to the currently released one. This may lead to confusion, as the link for the assets download is logged and makes people think that it's outdated.

I'm not a fan of creating a separate repository for everything, maybe we could host them in gh-pages branch of this same repo, serving not from the repository, but from GH Pages CDN instead?

Originally posted by @MaxDesiatov in #313 (comment)
@MaxDesiatov
Copy link
Collaborator Author

This was resolved by #334. We aren't using a CDN, entrypoints are now directly embedded in the binary.

@MaxDesiatov MaxDesiatov added the refactor No user-visible functionality change label May 11, 2022
@MaxDesiatov MaxDesiatov closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor No user-visible functionality change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaxDesiatov