-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 5.7.1 support #499
Add 5.7.1 support #499
Conversation
I don't see why from 87c8847 5.7 wasn't applied on windows as well, maybe CI will show us |
Hi @keith and thanks for the PR! Looks good only needs an update to the version resolver test 👍 |
I wonder if @compnerd has any advice |
updated the tests, hopefully we're good at least on macOS + ubuntu |
What has the issue(s) on Windows been? |
@compnerd this is the failed test action for Windows: https://github.com/swift-actions/setup-swift/actions/runs/3396434764/jobs/5669030944#step:5:393 I can't make anything of it really - it fails checking the swift --version but there aren't really any details in the error. @fwal any thoughts? It looks like swift.exe --version results in an error code but no stdout or stderr is logged |
3221225781 = 0xC0000135. I suspect that you are not refreshing the shell and as such are missing changes to |
@compnerd would |
I don't know that script, but if it works in any shape like what I do with compnerd/gha-setup-swift, it should work. |
avoided the windows bump for now, hoping this works as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good 👍
No description provided.