Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5.7.1 support #499

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Add 5.7.1 support #499

merged 1 commit into from
Nov 28, 2022

Conversation

keith
Copy link
Contributor

@keith keith commented Nov 4, 2022

No description provided.

@keith
Copy link
Contributor Author

keith commented Nov 4, 2022

I don't see why from 87c8847 5.7 wasn't applied on windows as well, maybe CI will show us

@fwal fwal self-requested a review November 7, 2022 07:52
@fwal
Copy link
Collaborator

fwal commented Nov 7, 2022

Hi @keith and thanks for the PR!

Looks good only needs an update to the version resolver test 👍
I've yet to look into the issues with windows and why it haven't worked since 5.7 😞

@fwal fwal added the enhancement New feature or request label Nov 7, 2022
@gregcotten
Copy link

I wonder if @compnerd has any advice

@keith
Copy link
Contributor Author

keith commented Nov 7, 2022

updated the tests, hopefully we're good at least on macOS + ubuntu

@compnerd
Copy link

compnerd commented Nov 7, 2022

What has the issue(s) on Windows been?

@gregcotten
Copy link

gregcotten commented Nov 7, 2022

What has the issue(s) on Windows been?

@compnerd this is the failed test action for Windows: https://github.com/swift-actions/setup-swift/actions/runs/3396434764/jobs/5669030944#step:5:393

I can't make anything of it really - it fails checking the swift --version but there aren't really any details in the error. @fwal any thoughts?

It looks like swift.exe --version results in an error code but no stdout or stderr is logged

@compnerd
Copy link

compnerd commented Nov 7, 2022

3221225781 = 0xC0000135. I suspect that you are not refreshing the shell and as such are missing changes to Path which results in DLLs not being found.

@gregcotten
Copy link

gregcotten commented Nov 7, 2022

3221225781 = 0xC0000135. I suspect that you are not refreshing the shell and as such are missing changes to Path which results in DLLs not being found.

@compnerd would choco refreshenv work, if we actually had choco installed on the runner? Or even just running RefreshEnv.cmd from the choco repo if we could include it somehow?

@compnerd
Copy link

compnerd commented Nov 7, 2022

I don't know that script, but if it works in any shape like what I do with compnerd/gha-setup-swift, it should work.

@keith
Copy link
Contributor Author

keith commented Nov 28, 2022

avoided the windows bump for now, hoping this works as is

Copy link
Collaborator

@fwal fwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good 👍

@fwal fwal merged commit c451d2c into swift-actions:main Nov 28, 2022
@keith keith deleted the ks/add-5.7.1 branch November 28, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants