-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use didOpen and didDestroy instead of deprecated onOpen and onDestroy #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be totally broken with sweetalert2 version < 10.3.0
Right, should we release the new major with peerDependency |
I don't like the idea of making a breaking change to deal with the hook name changes which supposed to be (and are themselves) backwards-compatible
Definitely possible.. I'm just not sure of the best way to go about it. We could decide dynamically which hook names (original or updated) to use:
There are some tricky edge cases there though, like what if we get a mix? (e.g. |
@zenflow should be good to go now, please review 🚀 |
I also added |
@zenflow I'll go ahead and merge this PR. Please review when you have time, thank you! |
## [3.2.1](v3.2.0...v3.2.1) (2020-10-13) ### Bug Fixes * use didOpen and didDestroy instead of deprecated onOpen and onDestroy ([#126](#126)) ([ce0f62d](ce0f62d))
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…stroy (#126) * use didOpen and didDestroy instead of deprecated onOpen and onDestroy * support legacy onOpen and odDestroy hooks as well * chore: bump yarn.lock * Add test-build-v9.html, add didOpen/didDestroy to test-build.html * fix eslint issues
## [3.2.1](v3.2.0...v3.2.1) (2020-10-13) ### Bug Fixes * use didOpen and didDestroy instead of deprecated onOpen and onDestroy ([#126](#126)) ([547efd4](547efd4))
Closes #125