Fixed error where crash will happen if fired twice in a row.

[robhybrid]

No description provided.

[limonte]

Thanks @robhybrid for the PR!

1. Could you please be more specific about "crashing"? I guess there should be an exception(s) thrown? If so, please provide the code to reproduce the issue.
2. You've added the test (which is great!) but it's passing for the current master without the if (domElement) { statement. So the test isn't really covering the issue you're trying to fix. Ideally, the test should fail without changes in the actual code.

[robhybrid]

I am getting the following error:

    unmountComponentAtNode(...): Target container is not a DOM element.

      45 |           params.onDestroy = (element) => {
      46 |             superOnDestroy(element)
    > 47 |             ReactDOM.unmountComponentAtNode(domElement)
         |                      ^
      48 |           }
      49 |         }
      50 |       })

      at Object.unmountComponentAtNode (node_modules/react-dom/cjs/react-dom.development.js:27628:13)
      at Object.params.onDestroy (src/index.js:47:22)

This happens with my test, and in my production application.

[robhybrid]

The test fails on the CI when my change is removed and passes when it is added back. There may be something out of sync with your local environment.

[limonte]

The test fails on the CI when my change is removed and passes when it is added back. There may be something out of sync with your local environment.

It was out of sync indeed, my apologies! Thanks a lot for the well-done contribution!

[limonte]

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀