Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(es/typescript): Improve enum comments and sourcemap #9652

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

magic-akari
Copy link
Member

No description provided.

@magic-akari magic-akari requested a review from a team as a code owner October 16, 2024 16:03
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: c99700a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #9652 will degrade performances by 8.93%

Comparing magic-akari:chore/ts-enum-comments (c99700a) with main (8a19201)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 190 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:chore/ts-enum-comments Change
es/full/bugs-1 533.1 µs 585.4 µs -8.93%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=true 1.4 ms 1.4 ms -3.24%
es/visitor/base-perf/boxing_boxed 3.4 µs 3.3 µs +3.52%
es/visitor/base-perf/boxing_boxed_clone 2.5 µs 2.4 µs +4.95%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant