Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/parser): Fix failure of TS instantiation followed by satisfies #9583

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Sep 24, 2024

Description:

BREAKING CHANGE:

Related issue (if exists):

it's already ok when followed by as.

closes #8627

@CPunisher CPunisher requested a review from a team as a code owner September 24, 2024 06:56
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 6382f5b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Sep 24, 2024

CodSpeed Performance Report

Merging #9583 will degrade performances by 5.9%

Comparing CPunisher:fix/satisfies-after-generic (6382f5b) with main (14cfd70)

Summary

⚡ 1 improvements
❌ 4 regressions
✅ 173 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main CPunisher:fix/satisfies-after-generic Change
es/full/codegen/es2015 291.4 µs 276.4 µs +5.4%
es/visitor/base-perf/boxing_boxed 3.1 µs 3.3 µs -4.45%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -3.63%
es/visitor/base-perf/boxing_unboxed 3.3 µs 3.5 µs -5.9%
es/visitor/base-perf/boxing_unboxed_clone 2.5 µs 2.6 µs -4.43%

magic-akari
magic-akari previously approved these changes Sep 24, 2024
@kdy1 kdy1 requested a review from a team as a code owner September 25, 2024 01:41
@kdy1 kdy1 self-assigned this Oct 1, 2024
@kdy1 kdy1 merged commit 77900d8 into swc-project:main Oct 1, 2024
155 checks passed
@kdy1
Copy link
Member

kdy1 commented Oct 1, 2024

Sorry for the late review. I forgot it because I didn't assign it to me.
https://github.com/issues?q=is%3Aopen+assignee%3Akdy1+archived%3Afalse+sort%3Aupdated-desc is my homepage, but this issue didn't show up there.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TS instantiation followed by satisfies or "as" expr fails to parse
3 participants