Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(es/codegen): Bump minimum required swc_allocator version to 0.1.8 #9492

Conversation

magurotuna
Copy link
Contributor

Description:

swc_ecma_codegen uses swc_allocator::collections modules:

use swc_allocator::{collections::FxHashSet, maybe::vec::Vec};

use swc_allocator::{collections::FxHashSet, maybe::vec::Vec};

collections module was added to swc_allocator in 0.1.8. However, swc_ecma_codegen still says that the minimum required version of swc_allocator is 0.1.7:

swc_allocator = { version = "0.1.7", path = "../swc_allocator", default-features = false }

This can cause a compile error when someone has a lockfile that pins swc_allocator 0.1.7, which is supposed to work with swc_ecma_codegen according to the manifest, but actually not.

BREAKING CHANGE:

N/A

Related issue (if exists):

N/A

@magurotuna magurotuna requested a review from a team as a code owner August 24, 2024 09:35
Copy link

changeset-bot bot commented Aug 24, 2024

🦋 Changeset detected

Latest commit: 1c0ac2d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codspeed-hq bot commented Aug 24, 2024

CodSpeed Performance Report

Merging #9492 will improve performances by 5.45%

Comparing magurotuna:bump-minimum-required-swc-allocator-version-in-ecma-codegen (1c0ac2d) with main (5258763)

Summary

⚡ 2 improvements
✅ 176 untouched benchmarks

Benchmarks breakdown

Benchmark main magurotuna:bump-minimum-required-swc-allocator-version-in-ecma-codegen Change
es/full/bugs-1 545.8 µs 522.8 µs +4.4%
es/full/codegen/es2015 291.3 µs 276.2 µs +5.45%

@kdy1 kdy1 added this to the Planned milestone Aug 24, 2024
@kdy1 kdy1 requested a review from a team as a code owner August 24, 2024 11:29
@kdy1 kdy1 changed the title chore(es/codegen): bump minimum required swc_allocator version to 0.1.8 chore(es/codegen): Bump minimum required swc_allocator version to 0.1.8 Aug 24, 2024
@kdy1 kdy1 merged commit 5258763 into swc-project:main Aug 24, 2024
10 checks passed
@magurotuna magurotuna deleted the bump-minimum-required-swc-allocator-version-in-ecma-codegen branch August 24, 2024 12:56
@kdy1 kdy1 modified the milestones: Planned, v1.7.19 Aug 28, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants