Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/typescript): Correctly handle deep import chains #9487

Merged
merged 4 commits into from
Aug 22, 2024
Merged

fix(es/typescript): Correctly handle deep import chains #9487

merged 4 commits into from
Aug 22, 2024
+18 −4

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari requested a review from a team as a code owner August 22, 2024 14:13
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 65a24a5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magic-akari magic-akari requested a review from a team as a code owner August 22, 2024 14:17
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9487 will improve performances by 3.36%

Comparing magic-akari:fix/issue-9486 (65a24a5) with main (1121bc0)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9486 Change
⚡ es/full/parser 1.5 ms 1.5 ms +3.36%

@kdy1 kdy1 added this to the Planned milestone Aug 22, 2024
@kdy1 kdy1 merged commit 50d70d3 into swc-project:main Aug 22, 2024
155 checks passed
@magic-akari magic-akari deleted the fix/issue-9486 branch August 23, 2024 01:20
@kdy1 kdy1 modified the milestones: Planned, v1.7.17 Aug 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.18
Development

Successfully merging this pull request may close these issues.

SWC incorrectly removes namespace import if it is used with import equals
2 participants
@magic-akari @kdy1