Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Mark LHS of for-in/of as update #9474

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 21, 2024

@kdy1 kdy1 added this to the Planned milestone Aug 21, 2024
@kdy1 kdy1 self-assigned this Aug 21, 2024
@kdy1 kdy1 requested a review from a team as a code owner August 21, 2024 04:36
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: d67cd0a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 21, 2024
@kdy1 kdy1 enabled auto-merge (squash) August 21, 2024 04:52
@kdy1 kdy1 disabled auto-merge August 21, 2024 05:02
@kdy1 kdy1 merged commit ac432c4 into swc-project:main Aug 21, 2024
153 checks passed
@kdy1 kdy1 deleted the issue-9466 branch August 21, 2024 05:02
Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #9474 will degrade performances by 9.22%

Comparing kdy1:issue-9466 (d67cd0a) with main (3ee8980)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 176 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:issue-9466 Change
es/full/bugs-1 548.6 µs 604.3 µs -9.22%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.5 µs +3.48%

@kdy1 kdy1 modified the milestones: Planned, v1.7.17 Aug 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

minifier: incorrectly removes functions and classes used in for statements
2 participants