Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/html): Allow using lightningcss as minfiier #9462

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 20, 2024

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Aug 20, 2024
@kdy1 kdy1 self-assigned this Aug 20, 2024
Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: cde39ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title feat(bindings/html): Allow using lightningcss as the CSS minfiier feat(bindings/html): Allow using lightningcss as minfiier Aug 20, 2024
@kdy1
Copy link
Member Author

kdy1 commented Aug 20, 2024

@hardfist I want to hear opinion about baking lightningcss part into swc_html_minifier itself.

@kdy1
Copy link
Member Author

kdy1 commented Aug 20, 2024

cc @devongovett for visibility 👍

@kdy1 kdy1 marked this pull request as ready for review August 20, 2024 06:41
@kdy1 kdy1 requested a review from a team as a code owner August 20, 2024 06:41
@kdy1 kdy1 enabled auto-merge (squash) August 20, 2024 06:41
@kdy1 kdy1 disabled auto-merge August 20, 2024 06:54
@kdy1 kdy1 merged commit 74d6478 into swc-project:main Aug 20, 2024
84 checks passed
@kdy1 kdy1 deleted the html-css branch August 20, 2024 06:54
@kdy1 kdy1 modified the milestones: Planned, v1.7.15 Aug 20, 2024
@hardfist
Copy link
Contributor

hardfist commented Aug 20, 2024

@hardfist I want to hear opinion about baking lightningcss part into swc_html_minifier itself.

I think it's ok if can be controlled by feature flag,
FYI rspack should use injected lightningcss(rspack's depdendency lightningcss) since we also use lightningcss in builtin loader and plugin, so it would be better to support avoid lightningcss version and feature conflict in userland.

Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #9462 will degrade performances by 8.66%

Comparing kdy1:html-css (cde39ed) with main (911d4ea)

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:html-css Change
es/full/bugs-1 526.5 µs 576.4 µs -8.66%

@kdy1 kdy1 modified the milestones: v1.7.17, Planned Aug 21, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants