Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(visit): Remove VisitAll #9448

Merged
merged 6 commits into from
Aug 19, 2024
Merged

refactor(visit): Remove VisitAll #9448

merged 6 commits into from
Aug 19, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 19, 2024

Description:

Technically this is a breaking change, but actually VisitAll was broken so I'll not mark this PR as a breaking change.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Aug 19, 2024
@kdy1 kdy1 self-assigned this Aug 19, 2024
@kdy1 kdy1 requested review from a team as code owners August 19, 2024 03:14
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 19, 2024
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 5189962

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) August 19, 2024 03:15
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 19, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 19, 2024
@kdy1 kdy1 disabled auto-merge August 19, 2024 03:48
@kdy1 kdy1 merged commit 8845b76 into swc-project:main Aug 19, 2024
153 checks passed
@kdy1 kdy1 deleted the issue-9346 branch August 19, 2024 03:48
Copy link

codspeed-hq bot commented Aug 19, 2024

CodSpeed Performance Report

Merging #9448 will not alter performance

Comparing kdy1:issue-9346 (5189962) with main (05961eb)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.7.13 Aug 19, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

VisitAll seems to work the same as Visit now
1 participant