Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/typescript): Handle single type statement in if/for/while #9364

Merged
merged 4 commits into from
Aug 1, 2024
Merged

fix(es/typescript): Handle single type statement in if/for/while #9364

merged 4 commits into from
Aug 1, 2024
+146 −7

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari requested review from a team as code owners August 1, 2024 06:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b5c64c8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 changed the title Fix (TypeScript): Handle single type statement in if/for/while fix(es/typescript): Handle single type statement in if/for/while Aug 1, 2024
@kdy1 kdy1 added this to the Planned milestone Aug 1, 2024
kdy1
kdy1 previously approved these changes Aug 1, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) August 1, 2024 06:10
@magic-akari
Copy link
Member Author

Wait for me to handle a case.

@magic-akari magic-akari marked this pull request as draft August 1, 2024 06:39
auto-merge was automatically disabled August 1, 2024 06:39

Pull request was converted to draft

@magic-akari magic-akari marked this pull request as ready for review August 1, 2024 06:50
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9364 will degrade performances by 3.04%

Comparing magic-akari:fix/ts-single-type-stmt (b5c64c8) with main (5368e18)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 176 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:fix/ts-single-type-stmt Change
❌ common/allocator/alloc/cached-no-scope/1000000 110.3 ms 113.8 ms -3.04%
⚡ parse_and_babelify_backbone 18.7 ms 17.8 ms +5.13%

@magic-akari magic-akari enabled auto-merge (squash) August 1, 2024 08:11
@magic-akari magic-akari merged commit 2217730 into swc-project:main Aug 1, 2024
155 checks passed
@magic-akari magic-akari deleted the fix/ts-single-type-stmt branch August 1, 2024 10:49
@kdy1
Copy link
Member

kdy1 commented Aug 1, 2024

I triggered a publish action for 1.7.5
https://github.com/swc-project/swc/actions/runs/10196903373

@kdy1 kdy1 modified the milestones: Planned, v1.7.5 Aug 2, 2024
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@magic-akari magic-akari mentioned this pull request Aug 19, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.5
Development

Successfully merging this pull request may close these issues.

unreachable error occurred by non-block TypeScript type statement
2 participants
@magic-akari @kdy1