Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/helpers): Use bool instead of AtomicBool #9321

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 23, 2024

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jul 23, 2024
@kdy1 kdy1 self-assigned this Jul 23, 2024
@kdy1 kdy1 requested review from a team as code owners July 23, 2024 05:30
Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: d59e313

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 23, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 23, 2024 05:30
@kdy1 kdy1 disabled auto-merge July 23, 2024 06:47
@kdy1 kdy1 merged commit 8107e98 into swc-project:main Jul 23, 2024
153 checks passed
@kdy1 kdy1 deleted the issue-9222 branch July 23, 2024 06:47
Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #9321 will degrade performances by 3.62%

Comparing kdy1:issue-9222 (d59e313) with kdy1:issue-9222 (1276336)

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark kdy1:issue-9222 kdy1:issue-9222 Change
parse_and_babelify_jquery 110.7 ms 114.8 ms -3.62%

@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Optimize swc_ecma_transforms_base::Helpers
1 participant