Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(visit): Add #[inline] #9302

Merged
merged 3 commits into from
Jul 20, 2024
Merged

perf(visit): Add #[inline] #9302

merged 3 commits into from
Jul 20, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 20, 2024

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jul 20, 2024
@kdy1 kdy1 self-assigned this Jul 20, 2024
Copy link

changeset-bot bot commented Jul 20, 2024

🦋 Changeset detected

Latest commit: b8c17ac

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Jul 20, 2024

CodSpeed Performance Report

Merging #9302 will degrade performances by 6.41%

Comparing kdy1:minifier-alloc (b8c17ac) with main (27ca712)

Summary

⚡ 2 improvements
❌ 4 regressions
✅ 172 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:minifier-alloc Change
es/visitor/base-perf/boxing_boxed 3.2 µs 3.4 µs -3.47%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -4.78%
es/visitor/base-perf/boxing_unboxed 3.4 µs 3.6 µs -6.41%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.7 µs -3.28%
html/document_fragment/visitor/compare/fold_span 1.3 ms 1.2 ms +4.22%
html/document_fragment/visitor/compare/fold_span_panic 1.3 ms 1.2 ms +4.44%

@kdy1 kdy1 marked this pull request as ready for review July 20, 2024 22:10
@kdy1 kdy1 requested review from a team as code owners July 20, 2024 22:10
@kdy1 kdy1 merged commit 0b3dbb8 into swc-project:main Jul 20, 2024
155 checks passed
@kdy1 kdy1 deleted the minifier-alloc branch July 20, 2024 22:11
@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant