Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(allocator): Remove wrong assertions and add tests #9252

Merged
merged 7 commits into from
Jul 15, 2024
Merged

fix(allocator): Remove wrong assertions and add tests #9252

merged 7 commits into from
Jul 15, 2024
+43 −7

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 15, 2024

Description:

@kdy1 kdy1 added this to the Planned milestone Jul 15, 2024
@kdy1 kdy1 marked this pull request as ready for review July 15, 2024 14:48
@kdy1 kdy1 requested a review from a team as a code owner July 15, 2024 14:48
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 15, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 14:48
kdy1
kdy1 commented Jul 15, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_allocator
  • swc_core

@kdy1 kdy1 merged commit d8e8b04 into swc-project:main Jul 15, 2024
155 checks passed
@kdy1 kdy1 deleted the alloc-test branch July 15, 2024 15:25
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 15, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9252 will not alter performance

Comparing kdy1:alloc-test (95dac7c) with kdy1:alloc-test (77e8b2a)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1