Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Emit named type in mapped types #9038

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

dsherret
Copy link
Contributor

Description:

Fixes the emit of mapped types.

Related issue (if exists): None

@dsherret dsherret requested a review from a team as a code owner June 11, 2024 16:49
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should consider switching these tests to use file_test_runner. It doesn't require recompiling when adding a test: https://github.com/denoland/file_test_runner (https://david.deno.dev/posts/file-test-runner/)

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds interesting. Does it support listing tests without running them? IIRC it was required for some reason.


swc-bump:

  • swc_core
  • swc_ecma_codegen

@kdy1 kdy1 enabled auto-merge (squash) June 12, 2024 00:42
@kdy1 kdy1 merged commit 91e92ec into swc-project:main Jun 12, 2024
148 checks passed
@dsherret dsherret deleted the fix_emit_mapped_type_name_type branch June 12, 2024 00:42
@dsherret
Copy link
Contributor Author

Yeah, the collection module allows for that: https://docs.rs/file_test_runner/0.7.2/file_test_runner/collection/index.html

It's two steps—collect and then run.

@kdy1 kdy1 modified the milestones: Planned, v1.5.29 Jun 13, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants