Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder for stable Rust #769

Closed
bartlomieju opened this issue May 14, 2020 · 6 comments · Fixed by #773
Closed

Folder for stable Rust #769

bartlomieju opened this issue May 14, 2020 · 6 comments · Fixed by #773
Assignees
@kdy1
Milestone
v1.1.43

Comments

@bartlomieju
Copy link
Contributor

Describe the feature
With amazing work done in #743 it's now possible to use Visitor in stable Rust - I use it extensively in both deno and deno_lint and it works like a charm! It would unlock a lot more possibilities if Folder could be made to work on stable Rust as well. @kdy1 I'm not that familiar with SWC code, but with some guidance I think I could try to get it working. Let me know what you think.

CC @dsherret
@kdy1
Copy link
Member

kdy1 commented May 14, 2020

I'll write one at the weekend.

@bartlomieju bartlomieju mentioned this issue May 15, 2020
Closed
@kdy1 kdy1 mentioned this issue May 16, 2020
Merged
@kdy1 kdy1 self-assigned this May 16, 2020
@kdy1 kdy1 closed this as completed in #773 May 16, 2020
@kdy1
Copy link
Member

kdy1 commented May 16, 2020

I implemented it and published [email protected]

@kdy1
Copy link
Member

kdy1 commented May 16, 2020

cc @ry

@bartlomieju
Copy link
Contributor Author

@kdy1 thank you! I will try it out this weekend

@kdy1 kdy1 added this to the v1.1.43 milestone May 16, 2020
@dsherret
Copy link
Contributor

Thanks a lot @kdy1!

@bartlomieju FYI, I am updating deno doc to use the latest swc right now.

@swc-bot
Copy link
Collaborator

swc-bot commented Oct 27, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.1.43
Development

Successfully merging a pull request may close this issue.

Folder for stable rust kdy1/swc
4 participants
@dsherret @bartlomieju @kdy1 @swc-bot