fix(register): exclude internal js files from compilation process #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I encountered an issue to upgrade a monorepo to
@swc-node/register
version1.10.0
. See the PR and the workflow run.The issue was that a TS file imported a JS file from within the monorepo (from an internal package).
@swc-node/register
propertly excluded plain JS file located in thenode_modules
folder from being sent toswc
for compilation, however, the logic failed when the plain JS file was located outside ofnode_modules
.In my understanding, checking whether a file is located in
node_modules
is irrelevant. What matters is:swc
, then pass the js result to nodeThis PR therefore reduces the check. It will only validate that the file is not a ts file in order to return early.
Also since I remove the check with the
AVAILABLE_EXTENSION_PATTERN
regex, it became unused so I deleted it. LMK if I should leave it there.