-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swaylock crashes after returning from hybernation #164
Comments
Please provide a stack trace. You can do so by running |
Xyene, when do I perform this stack trace? I just installed gdb and executed those commands, and then it shows the following:
|
That's not the right app (looks like If you do |
This is the sway stacktrace:
|
The backtrace you provided doesn't contain debug symbols. This most likely happens because the Sway binary you're using doesn't have debug information bundled. Can you try again with a manually compiled Sway binary? See https://github.com/swaywm/sway/wiki/Development-Setup#compiling-as-a-subproject |
I am now running sway build using:
I am using my normal sway config file and swaybar, etc. |
I got a crash when running swaylock with asan:
It looks like asan usage did not trigger a coredump, so I dont have a crashdump. swaylock 1.5 |
I have a new coredump:
After this I press
After typing
I do hope this is useful for you... and just for your info: sway version 1.5-89b4bc4b (Feb 3 2021, branch 'master') It seems easy to reproduce. I simple unplug the power connector and the external monitor. Then I close the lid. I wait for about a minute. After opening I get the error as presented above. |
I do understand that this is not an issue that is easy to debug. But since it is extremely serious, I would humbly suggest that the developers add a very prominent warning to swaylock to ensure that people cannot expect their screens to stay locked after hibernation. This way, people can at least take precautions such as disallowing that untrusted third parties initiate hibernation (like a passer-by closing a laptop lid). |
We are not going to add such a warning. swaylock is a normal application, and it crashing simply means that its window goes away - hibernation isn't the only swaylock crash bug. See swaywm/wlroots#2706 for discussion on ways to "harden" the screenlocker usecase. It should of course be noted that from a security standpoint, physical access to a running computer fully logged in (which it is when it is merely showing a lockscreen) means "game over", so if you are very security conscious you should log out to have encrypted home folders unmount, or power off to have full disk encryption be of use. |
Kenny Levinsen ***@***.***> writes:
It should of course be noted that from a security standpoint, physical access to a running computer fully logged in (which it is when it is merely showing a lockscreen) means "game over", so if you are very security conscious you should log out to have encrypted home folders unmount, or power off to have full disk encryption be of use.
I have a hard time understanding this threat model. Of course, full
physical access can mean game over. But if that's the threat model,
there's surely no point having a screen locker at all? What's swaylock's
raison d'être if it's not locking a person with *casual* physical access
to the device out of completely unrestricted access to the logged in
user's session?
|
Read the issue I linked. |
I use sway with swaylock on Arch Linux.
sway version 1.5.1
swaylock version 1.4
During use, I close the laptop lid and the laptop goes into sleep and later into hybernation.
After opening the lid, the laptop boots (via grub2) and returns to the swaylock state. So I have to provide my fingerprint (to the fingerprint reader) and swaylock provided access to sway.
However, the last few times swaylock (or sway?) crashed after the boot. The user then drops into the TTY without asking credentials. From there the user can restart sway again.
The crash is bad enough, but dropping to the TTY without providing credentials is a real problem.
I would like to help in providing a more detailed bugreport, but I am not sure how to do this. Please let me know if and what other information you need (and how I can obtain that information).
The text was updated successfully, but these errors were encountered: