Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer-shell surfaces can display over swaylock #107

Closed
kennylevinsen opened this issue Sep 3, 2019 · 5 comments
Closed

layer-shell surfaces can display over swaylock #107

kennylevinsen opened this issue Sep 3, 2019 · 5 comments
Labels

Comments

@kennylevinsen
Copy link
Member

layer-shell surfaces can display over swaylock, allows interaction with applications despite the session being locked.

wldash, for example, will display over swaylock if left open when swaylock starts. This allows full access to a functioning launcher while the session is locked.

Lockscreens need some mechanism to guarantee that they're the only visible and focused surface on every output.

@ddevault
Copy link
Contributor

ddevault commented Sep 3, 2019

This is by design. Some people want to, for example, show notifications even if the screen is locked (though wldash is wrong to use the overlay layer). However, the input inhibit protocol should give swaylock exclusive access to input events, preventing these applications from being interacted with.

@kennylevinsen
Copy link
Member Author

kennylevinsen commented Sep 4, 2019

If the overlay layer is meant to show over lock screens, we need to have a warning somewhere, at least in the protocol text where I couldn't see any mention of special interpretations. I only discovered this by accident. I chose overlay based on the protocol documentation, picking what seemed the most logical for a HUD-style overlay surface.

It's less severe with working input inhibition, but wldash captures the keyboard when running over swaylock. It also captures if using a top layer under a full-screen surface (but only after a few key-presses for some reason).

(Also, side-note: I can't get wldash to show if swaylock is started first, so I imagine notifications won't show either as is.)

@tmccombs
Copy link

tmccombs commented Apr 1, 2020

Some people want to, for example, show notifications even if the screen is locked

otoh, some people (including me) don't want to show notifications if the screen is locked. But if the layer is top instead of overlay, then it won't show above full-screen apps.

On the linked bemenu issue it was suggested that perhaps there should be another layer that is above full-screen apps, but below the lock screen, that would be suitable for things like launchers and notifications if the user doesn't want them to appear while locked.

@mstoeckl
Copy link
Contributor

mstoeckl commented Mar 12, 2023

This (and a few similar issues) can be closed: since ac3b49b, swaylock only uses ext-session-lock-v1, which does not have this issue.

@emersion
Copy link
Member

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants