Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mako notifications stay "burnt in" until screen/region updates otherwise #6914

Closed
HarHarLinks opened this issue Mar 23, 2022 · 6 comments
Closed
Labels
bug Not working as intended renderer Related to Sway's renderer

Comments

@HarHarLinks
Copy link

Please fill out the following:

 input type:keyboard {
    xkb_layout "de"
    xkb_model "pc105"
    xkb_capslock disabled
    xkb_numlock enabled
    xkb_options numpad:microsoft
}
input type:pointer {
    accel_profile flat
    dwt disabled
    left_handed disabled
    natural_scroll disabled
    pointer_accel -0.4
    scroll_button BTN_MIDDLE
    scroll_method on_button_down
}
output DP-1 {
    res 2560x1440
    pos 1920 0
    adaptive_sync on
}
output DP-2 {
    res 1080x1920@60Hz
    pos 4480 0
    transform 270
}
output HDMI-A-1 {
    res 1920x1080@60Hz
    pos 0 360
}
output HDMI-A-2 {
    res 1920x1080@60Hz
    pos 5530 0
}
focus output DP-1
set $mod Mod4
bindsym $mod+Return exec urxvtc -ls
bindsym $mod+Shift+q kill
bindsym $mod+Left focus left
bindsym $mod+Down focus down
bindsym $mod+Up focus up
bindsym $mod+Right focus right
bindsym $mod+Shift+Left move left
bindsym $mod+Shift+Down move down
bindsym $mod+Shift+Up move up
bindsym $mod+Shift+Right move right
bindsym $mod+Control+j move workspace to output left
bindsym $mod+Control+k move workspace to output down
bindsym $mod+Control+i move workspace to output up
bindsym $mod+Control+l move workspace to output right
bindsym $mod+Control+Left move workspace to output left
bindsym $mod+Control+Right move workspace to output right
bindsym $mod+less split h
bindsym $mod+minus split v
bindsym $mod+Shift+c reload
bindsym $mod+Shift+r restart
bindsym $mod+Shift+e exec "swaynag -t warning -m 'You pressed the exit shortcut. Do you really want to exi ? This will end your session.' -b 'Yes, exit' 'swaymsg exit'"

Here is a video of the test case for x in 1 2 3 4 5; do notify-send "test" "message $x"; done:

mako.mp4

As you can see, clicking to dismiss a notification makes the others move down, yet they also stay burnt in at their old position. It looks particularly weird if notifications have different heights.

Any update to the screen area will "flush" the lingering notification, that includes switching to (from?) the window behind it. Thus the issue mainly appears when there is no window open on the monitor, e.g. on boot or with a multi monitor setup. The interaction with the mouse cursor wiping the notifications away, while illustrating my point about updating the screen area, actually appears only during recording with wf-recorder - I can normally only get windows to clear them.

Per the original issue, emersion said to try sway -Ddamage=rerender which did help work around the issue.

My platform is arch's core/linux kernel (currently 5.16.16), mako 1.6-3, sway 1.7-2, wlroots 0.15.1-3, gdm 41.3-2.

@HarHarLinks HarHarLinks added the bug Not working as intended label Mar 23, 2022
@rpigott rpigott added the renderer Related to Sway's renderer label Mar 24, 2022
@Nefsen402
Copy link
Member

Does #6844 help?

@HarHarLinks
Copy link
Author

what would testing it entail? clone master, merge PR, build manually? do I need a git version of wlroots?

@Nefsen402
Copy link
Member

Yeah, you need wlroots from git. You can also just pull in the source branch of the PR directly for now, I rebased recently so there shouldn't be conflicts with git wlroots. To test, just run mako and see if the "burn in" remains.

@johannlejeune
Copy link

I just came across this issue and I'm experiencing something similar, although not exactly the same behavior.
On my side, when I receive multiple notifications at once, some notifications start to flicker until I move my cursor back into the screen (when the notifications appear while my cursor is on the screen, I need to move it out of the screen and back in).
I've had this issue for a very long time (maybe more than a year), I just didn't take the time to report it 🙈
#6844 seems to fix the issue, I'm gonna run this fork for now 🤷

Don't know if it's related, if it's not, I'll create a new issue 👍

VID_20220528_112311_01.mp4

@HarHarLinks
Copy link
Author

Don't know if it's related, if it's not, I'll create a new issue

Yes, it looks like in your video for me too sometimes. I think using a screen recorder as I did changes the effect slightly, you seem to have used an external camera.

@vyivel
Copy link
Member

vyivel commented Jan 18, 2024

Closed by #6844.

@vyivel vyivel closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended renderer Related to Sway's renderer
Development

No branches or pull requests

5 participants