Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks in title bars are not updated when set on current container with children #5460

Closed
lbonn opened this issue Jun 16, 2020 · 5 comments
Closed
Labels
bug Not working as intended renderer Related to Sway's renderer

Comments

@lbonn
Copy link
Contributor

lbonn commented Jun 16, 2020

sway version 1.4-90d936d4 (Jun 13 2020, branch 'master')

Steps to reproduce:

  • create a container with children (e.g: H[a b])
  • prepare a command to set a mark sleep 2; swaymsg 'mark xx'
  • focus on H[a b] before sleep finishes

H[a b] should then have "[xx]" in its title bar but it does not show until focus is moved to some other container.

An interesting variant (how I found this) is when I use rofi with some script to get a mark name as input and apply it on the currently focused container (H[a b]), the mark string appears but blinks at roughly 1Hz.

Maybe a damage tracking issue?

@lbonn
Copy link
Contributor Author

lbonn commented Jun 16, 2020

After more tests, it seems that the blinking coincides with my bar (swaybar) refreshing the time and the second bug does not occur when sway is run without a bar (refresh is immediate).

However, the first reproducers still occurs with no bar.

@emersion
Copy link
Member

Very likely a damage tracking issue indeed.

@emersion emersion added bug Not working as intended renderer Related to Sway's renderer labels Jun 16, 2020
@lbonn
Copy link
Contributor Author

lbonn commented Jun 16, 2020

Another clue: I can only reproduce the blinking using a layer shell menu (bemenu or rofi modified to use layer shell). If I use stock rofi using x11, I get no blink and immediate refresh.

@vyivel
Copy link
Member

vyivel commented Jan 18, 2024

Should be closed by #6844.

@vyivel vyivel closed this as completed Jan 18, 2024
@lbonn
Copy link
Contributor Author

lbonn commented Feb 28, 2024

Just confirming that it's not happening anymore (sway version 1.10-dev-829c75b9 (Feb 27 2024, branch 'master'))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended renderer Related to Sway's renderer
Development

No branches or pull requests

3 participants