Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

Double stringified response on hashtagItemsChanged #128

Open
xardass opened this issue May 29, 2018 · 2 comments · May be fixed by #169 or #187
Open

Double stringified response on hashtagItemsChanged #128

xardass opened this issue May 29, 2018 · 2 comments · May be fixed by #169 or #187

Comments

@xardass
Copy link
Collaborator

xardass commented May 29, 2018 •
edited
Loading

The reply object on hashtagItemsChanged is stringified once too often, I have to parse it twice:
this.hashtag = JSON.parse(JSON.parse(reply.data));

Example of reply on hashtagItems:

{"name":"Settler","stats":{"paidNoConflict":69,"resolved":23,"seekers":42,"providers":12},"description":"Settler is the first amazing hashtag","maintainer":{"avatarHash":"","username":"Mungo Weber","address":"0x3847F87F3EcF4a0e57djF73B2Db92134e1983ef5"},"hashtagFee":500000000000000000,"items":[{}]}

Example of reply on hashtagItemsChanged:

"{\"name\":\"Settler\",\"stats\":{\"paidNoConflict\":69,\"resolved\":23,\"seekers\":42,\"providers\":12},\"description\":\"Settler is the first amazing hashtag\",\"maintainer\":{\"avatarHash\":\"\",\"username\":\"Mungo Weber\",\"address\":\"0x3847F87F3EcF4a0e57djF73B2Db92134e1983ef5\"},\"hashtagFee\":500000000000000000,\"items\":[{}]}"

Notice the extra quotation marks
@xardass xardass assigned eduadiez and unassigned eduadiez May 29, 2018
@xardass xardass changed the title Double stringified respons on hashtagItemsChanged Double stringified response on hashtagItemsChanged May 30, 2018
@kingflurkel
Copy link
Contributor

still valid?

@xardass
Copy link
Collaborator Author

xardass commented Aug 13, 2018

Yes, still valid

@snyk-bot snyk-bot linked a pull request Jan 21, 2020 that will close this issue
Open
@snyk-bot snyk-bot linked a pull request Sep 12, 2021 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kingflurkel @eduadiez @xardass