Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger UI loads assets from http://fonts.googleapis.com #226

Closed
pklanka opened this issue Aug 7, 2022 · 3 comments
Closed

Swagger UI loads assets from http://fonts.googleapis.com #226

pklanka opened this issue Aug 7, 2022 · 3 comments

Comments

@pklanka
Copy link

pklanka commented Aug 7, 2022

Swagger UI moved away from google fonts in 2018 (ref: swagger-api/swagger-ui#4598). Could we please remove this dependency. It is making a obnoxious network call in a secluded env.
@pklanka pklanka changed the title Swagger UI loads fonts from http://fonts.googleapis.com Swagger UI loads assets from http://fonts.googleapis.com Aug 7, 2022
@pklanka
Copy link
Author

pklanka commented Aug 7, 2022

Issue seems here -

gin-swagger/swagger.go

Line 230 in b9e926c

<link href="https://fonts.googleapis.com/css?family=Open+Sans:400,700|Source+Code+Pro:300,600|Titillium+Web:400,600,700" rel="stylesheet">
and I think we can safely remove this line and let default fonts take over?

@ubogdan ubogdan mentioned this issue Aug 9, 2022
Merged
@ubogdan
Copy link
Contributor

ubogdan commented Aug 9, 2022

@pklanka Thanks for letting us know.
The fix is available in v1.5.2

This was referenced Aug 9, 2022
Merged
Merged
@pklanka
Copy link
Author

pklanka commented Aug 10, 2022

Thanks so much for the update

@pklanka pklanka closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ubogdan @pklanka