Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): revert to redux@3 and react-redux@4 #6331

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Aug 20, 2020

Description

Motivation and Context

Redux@4 breaking change: Forbid subscribe() and getState() while reducer is running. Ref here

SwaggerUI has multiple instances where this exists.
PR #6330 addresses one such instance, where it was visible in Swagger Editor render

A separate issue will be created for Redux@4 migration.

How Has This Been Tested?

Swagger Editor unit tests will catch these breaking changes. Reverting back to redux@3 results in passing unit tests.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai mentioned this pull request Aug 20, 2020
@tim-lai tim-lai merged commit e82aaae into swagger-api:master Aug 20, 2020
@tim-lai tim-lai mentioned this pull request Jun 17, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant