Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): expose config and make it overridable #9862

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat(config): expose config and make it overridable #9862

merged 1 commit into from
Apr 22, 2024

Conversation

char0n
Copy link
Member

@char0n char0n commented Apr 22, 2024 •
edited
Loading

These changes make ti possible to integrate config in SwaggerEditor@5. The config is exposed in a way that it allow to do additional things:

  • read/override config defaults
  • supply custom merge function
  • supply additional type casting mapping or remove existing ones

@char0n char0n self-assigned this Apr 22, 2024
glowcloud
glowcloud approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@char0n char0n merged commit 17d50a6 into master Apr 22, 2024
8 checks passed
@char0n char0n deleted the char0n/overridable-config branch May 13, 2024 10:55
@leika leika mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glowcloud glowcloud glowcloud approved these changes

Assignees

@char0n char0n

Labels
type: enhancement version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@char0n @glowcloud